Fix issue with EdgesTable Grid wrapper #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cintia Sanchez Garcia <cynthiasg@icloud.com>
cynthia-sg
commented
Nov 20, 2019
| @@ -380,15 +380,11 @@ export class ResourceDetailBase extends React.Component { | |||
| isTcpTable={true} | |||
| metrics={this.state.podMetrics} /> | |||
|
|
|||
| <Grid container direction="column" justify="center"> | |||
| <Grid item> | |||
There was a problem hiding this comment.
Another solution would be to add prop xs={12} to Grid item, but I think that removing these extra Grids is better.
|
Great fix! To test this PR, I used the Chrome DevTools "Toggle Device Toolbar" button: to toggle mobile view. I looked at the detail page for a Pod in
then I looked at the detail page in this branch and saw that the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Gridwrapper aroundEdgesTablecomponent in resource detail page.Fixes #3601
Signed-off-by: Cintia Sanchez Garcia cynthiasg@icloud.com