-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edge-20.1.2 #3931
edge-20.1.2 #3931
Conversation
CHANGES.md
Outdated
* CLI | ||
* Added HA specific checks to `linkerd check` to ensure that the `kube-system` | ||
namespace has the `config.linkerd.io/admission-webhooks:disabled` | ||
annotation set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a label 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
CHANGES.md
Outdated
@@ -1,3 +1,20 @@ | |||
## edge-20.1.2 | |||
|
|||
**Note**: The `linkerd-proxy` version included with this release is more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're back to a master proxy in this version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we're not... yet. We will be, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olix0r @grampelberg Should add note that we are back to non-experimental under the Proxy changes section?
CHANGES.md
Outdated
* Added HA specific checks to `linkerd check` to ensure that the `kube-system` | ||
namespace has the `config.linkerd.io/admission-webhooks:disabled` | ||
label set | ||
* Fixed a problem causing the presence of unnecessary fields in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe emphasize that it's unnecessary empty fields, so that users who version-control the Linkerd YAML know what to expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ihcsim made a good point, otherwise LGTM!
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
8b5f244
to
6315399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
edge-20.1.2
linkerd check
to ensure that thekube-system
namespace has the
config.linkerd.io/admission-webhooks:disabled
label set
generated resource definitions (thanks @mayankshah1607)
the value of
linkerd.io/inject
is eitherenabled
ordisabled
(thanks @mayankshah1607)
Signed-off-by: Zahari Dichev zaharidichev@gmail.com