Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge-20.1.2 #3931

Merged
merged 3 commits into from
Jan 16, 2020
Merged

edge-20.1.2 #3931

merged 3 commits into from
Jan 16, 2020

Conversation

zaharidichev
Copy link
Member

@zaharidichev zaharidichev commented Jan 15, 2020

edge-20.1.2

  • CLI
    • Added HA specific checks to linkerd check to ensure that the kube-system
      namespace has the config.linkerd.io/admission-webhooks:disabled
      label set
    • Fixed a problem causing the presence of unnecessary empty fields in
      generated resource definitions (thanks @mayankshah1607)
  • Proxy
    • Fixed an issue that could cause the OpenCensus exporter to stall
  • Internal
    • Added validation to incoming sidecar injection requests that ensures
      the value of linkerd.io/inject is either enabled or disabled
      (thanks @mayankshah1607)

Signed-off-by: Zahari Dichev zaharidichev@gmail.com

CHANGES.md Outdated
* CLI
* Added HA specific checks to `linkerd check` to ensure that the `kube-system`
namespace has the `config.linkerd.io/admission-webhooks:disabled`
annotation set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a label 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

CHANGES.md Outdated
@@ -1,3 +1,20 @@
## edge-20.1.2

**Note**: The `linkerd-proxy` version included with this release is more
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're back to a master proxy in this version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we're not... yet. We will be, though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olix0r @grampelberg Should add note that we are back to non-experimental under the Proxy changes section?

CHANGES.md Outdated
* Added HA specific checks to `linkerd check` to ensure that the `kube-system`
namespace has the `config.linkerd.io/admission-webhooks:disabled`
label set
* Fixed a problem causing the presence of unnecessary fields in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe emphasize that it's unnecessary empty fields, so that users who version-control the Linkerd YAML know what to expect.

Copy link
Contributor

@cpretzer cpretzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihcsim made a good point, otherwise LGTM!

Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Copy link
Contributor

@admc admc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zaharidichev zaharidichev merged commit 65aad4e into master Jan 16, 2020
@olix0r olix0r deleted the zd/edge-20.1.2 branch October 13, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants