Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: Do not run tests on push to main #6872

Closed
wants to merge 1 commit into from
Closed

Conversation

olix0r
Copy link
Member

@olix0r olix0r commented Sep 13, 2021

Each time we push to the main branch, we run a full set of unit and
integration tests, even though the branch has already passed CI before
merging. When we have many branches in-flight, this work chews into our
actions usage, delaying actions for open PRs that are more important to
run expediently.

This change disables running these tests on push to main. We continue
to run CodeQL checks on main, as these checks appear to be necessary.

Each time we push to the main branch, we run a full set of unit and
integration tests, even though the branch has already passed CI before
merging. When we have many branches in-flight, this work chews into our
actions usage, delaying actions for open PRs that are more important to
run expediently.

This change disables running these tests on push to `main`. We continue
to run `CodeQL` checks on main, as these checks appear to be necessary.
@olix0r olix0r requested a review from a team as a code owner September 13, 2021 20:53
@olix0r
Copy link
Member Author

olix0r commented Sep 13, 2021

image

Note that this failure there isn't even a true failure -- there was an error pulling the Debian docker image.

@alpeb
Copy link
Member

alpeb commented Sep 14, 2021

One thing that the CI failure in #6873 promptly reminded me is that all the docker layer caches are rooted at the caches generated in the main branch (see the docs for a detailed description). This vastly speeds up builds in PRs, even external ones. So at a minimum, I think we should keep on building the images in main.

@olix0r olix0r marked this pull request as draft September 14, 2021 00:30
@olix0r olix0r closed this Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants