Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Navbar.vue #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Navbar.vue #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/components/Navbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
</a>
<a @click="locale = 'zh_CN'; $i18n.locale = locale; dropdownVisible = false"
class="cursor-pointer block px-4 py-2 hover:bg-base-300 dark:hover:bg-base-dark-400 transition-colors flex gap-2 items-center">
<p class="flex-1 pr-2">中文 (中国)</p>
<p class="flex-1 pr-2">中文（中国大陆）</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add these unrelated changes, this is normal for Countries / Regions dropdowns

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With reference to the language list of Minecraft and Microsoft/Xbox.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really doesn't matter, this is an unrelated change. On the other note, pretty much most regions dropdowns use China (e.g. Discord), this isn't a nationality dropdown so there isn't an enticing reason to clarify the difference.

<svg xmlns="http://www.w3.org/2000/svg" width="1em" height="1em" preserveAspectRatio="xMidYMid meet"
viewBox="0 0 36 36">
<path fill="#DE2910" d="M36 27a4 4 0 0 1-4 4H4a4 4 0 0 1-4-4V9a4 4 0 0 1 4-4h28a4 4 0 0 1 4 4v18z"/>
Expand All @@ -68,7 +68,7 @@
</a>
<a @click="locale = 'zh_TW'; $i18n.locale = locale; dropdownVisible = false"
class="cursor-pointer block px-4 py-2 hover:bg-base-300 dark:hover:bg-base-dark-400 transition-colors flex gap-2 items-center">
<p class="flex-1 pr-2">中文 (台灣)</p>
<p class="flex-1 pr-2">中文（台灣）</p>
<svg xmlns="http://www.w3.org/2000/svg" width="1em" height="1em" preserveAspectRatio="xMidYMid meet"
viewBox="0 0 36 36">
<path fill="#FE0000" d="M32 5H17v13H0v9a4 4 0 0 0 4 4h28a4 4 0 0 0 4-4V9a4 4 0 0 0-4-4z"/>
Expand Down Expand Up @@ -160,4 +160,4 @@ export default defineComponent({
</script>

<style scoped>
</style>
</style>