Update Navbar.vue #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
中文环境下使用全角标点更加合适
shedaniel
reviewed
Feb 17, 2023
| @@ -58,7 +58,7 @@ | |||
| </a> | |||
| <a @click="locale = 'zh_CN'; $i18n.locale = locale; dropdownVisible = false" | |||
| class="cursor-pointer block px-4 py-2 hover:bg-base-300 dark:hover:bg-base-dark-400 transition-colors flex gap-2 items-center"> | |||
| <p class="flex-1 pr-2">中文 (中国)</p> | |||
| <p class="flex-1 pr-2">中文（中国大陆）</p> | |||
There was a problem hiding this comment.
Please do not add these unrelated changes, this is normal for Countries / Regions dropdowns
There was a problem hiding this comment.
With reference to the language list of Minecraft and Microsoft/Xbox.
There was a problem hiding this comment.
It really doesn't matter, this is an unrelated change. On the other note, pretty much most regions dropdowns use China (e.g. Discord), this isn't a nationality dropdown so there isn't an enticing reason to clarify the difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文环境下使用全角标点更加合适