Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifying docs on id_prefixes and adding explicit documentation on elipses ... syntax #29

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Clarifying docs on id_prefixes and adding explicit documentation on elipses ... syntax #29

merged 2 commits into from
Jun 30, 2021

Conversation

cmungall
Copy link
Member

No description provided.

@cmungall cmungall requested a review from hsolbrig June 18, 2021 19:45
hsolbrig
hsolbrig reviewed Jun 18, 2021
View reviewed changes
Copy link
Contributor

@hsolbrig hsolbrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... is not a valid ncname, so we'd have to change the range to include it. While I don't have a strong opinion, I weakly favor explicit semantics (e.g. "open": true vs. "if '...' in prefix list...

@cmungall
Copy link
Member Author

OK - we said ... on a call in April, see linkml/linkml#194 (comment)

but happy to go with other scheme

hsolbrig
hsolbrig requested changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@hsolbrig hsolbrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the elipses comment line until we actually know what and how we are going to implement it. As is this pull commits us to some immediate tasks

@cmungall
Copy link
Member Author

ok, removed the comment on elipses until we decide on open vs closed prefixes

@hsolbrig hsolbrig merged commit fea5283 into main Jun 30, 2021
@hsolbrig hsolbrig deleted the linkml-issue-194 branch June 30, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsolbrig hsolbrig hsolbrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmungall @hsolbrig