-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
id_prefixes: allow for open vs closed and additional metadata #194
Comments
See disease class in biolink model |
We need to decide whether id_prefixes should be interpreted as a "should" or a "must". Note: Tie this in to the issue about "strict" ... |
See microbiomedata/nmdc-metadata#308 for use case |
Decision: id_prefixes can include "..." as last element, which says informative vs. check |
Proposal discussed on linkml call:
|
In the above example, the id_prefixes operate at the class level. So, I suppose that two different classes could have the same Do you want to allow for the |
@wdduncan good point. The idea was that different classes may have different rules. E.g. ZFIN has different local id syntaxes for genes, genotypes, etc. But in many cases the same format is used across different types. Note for these cases we can leverage bioregistry.io |
…lipses ... syntax See #28 and linkml/linkml#194
It seems we have walked back on the idea of using Do we have an alternative proposal? note that id_prefixes is now a list, so we can't embed something within it, so it would have to be a sibling key, e.g. class: Foo
id_prefixes:
- GO
- MESH
- NCIT
id_prefixes_meta:
closed: True we could also have this at the level of the whole schema, so that by default we could have all of them be open or closed. |
another piece of information is whether the idprefixes should be inherited or not |
I would also be interested to hear other's thoughts on if id_prefixes field should be allowed on an abstract class. |
and can a logical assumption be made that a parent class id-space is the sum of its children's id-spaces? |
Discussed on todays call
default semantics of id_prefixes and inheritance. Proposal:
|
See closed issue linkml/linkml-model#28 for further discussion |
alternate proposal from @hsolbrig: Use
|
Notes from today's call: we are rejecting the We discussed 3 options option 1, allows for more metadata:
option 2: direct
option 3:
We decided on 2. Note that open is the default (but validators may choose to emit warnings if prefix not in the list) We also discussed use cases around profiling - models intended to be reused in many contexts like biolink would leave these open but profiles could close them |
Right now, any id that instantiates a class should have a curie in the set of id_prefixes class. This needs to be incorporated into the id loader
The text was updated successfully, but these errors were encountered: