Enhance import_map functionality to support namespace as well as indi… #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vidual file mapping. Also separated out import mapping code so that linkml can use the same code as the utilities.
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 62.54% 63.81% +1.26%
==========================================
Files 49 49
Lines 5219 5217 -2
Branches 1468 1463 -5
==========================================
+ Hits 3264 3329 +65
+ Misses 1593 1523 -70
- Partials 362 365 +3
Continue to review full report at Codecov.
|
|
@cmungall - I need this to be in pypi before I can commit a corresponding linkml change. What is the process these days? |
|
same as before - just make a new github release, actions will propagate to pypi See the docs: https://github.com/linkml/linkml-runtime/blob/main/CONTRIBUTING.md#release-process |
cmungall
reviewed
Apr 11, 2022
| @@ -50,6 +50,17 @@ def to_file_uri(fname: str) -> str: | |||
| JsonObj(**{"@context": context_list[0] if len(context_list) == 1 else context_list}) | |||
|
|
|||
|
|
|||
| def map_import(importmap: Dict[str, str], namespaces: Callable[[None], "Namespaces"], imp: Any) -> str: | |||
| sname = str(imp) | |||
There was a problem hiding this comment.
a docstring would be great here
cmungall
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vidual file mapping.
Also separated out import mapping code so that linkml can use the same code as the utilities.