Compatible with Symfony 5 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the User class no longer implements Symfony's AdvancedUserInterface which was removed in Symfony 5. Instead of using the methods of the removed interface, integrators should implement User and Account checks in UserCheckers. The LegacyAdvancedUserInterface is available as a last resort.
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allow the client library to be used in Symfony 5 projects.
Breaking Change
The
Userclass no longer implements Symfony'sAdvancedUserInterfacewhich was removed in Symfony 5. Instead of usingthe methods of the removed interface, integrators should implement User
and Account checks in
UserCheckers.A temporary replacement for the removed interface is
UserBase\Client\Model\LegacyAdvancedUserInterface, but use this only as alast resort and as a temporary fix.