Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one-line fix to #330 #739

Merged
merged 3 commits into from Sep 2, 2019
Merged

one-line fix to #330 #739

merged 3 commits into from Sep 2, 2019

Conversation

jamescheney
Copy link
Contributor

I was just reading #330 randomly, and wondered whether this one-line fix suffices. It does allow Daniel's example to be parsed:

links> sig f : () {:a,wild}-> () fun f() { () };
f = fun : () {:_}~> ()

but perhaps there are other negative consequences which are the reason this issue has been hanging around for over a year. @dhil?

@jamescheney
Copy link
Contributor Author

This seems unproblematic, at least as far as existing tests are concerned. (the MacOS tests failed the first time for random-looking reasons.) Will merge Monday if there are no objections by then.

@dhil
Copy link
Member

dhil commented Sep 1, 2019

but perhaps there are other negative consequences which are the reason this issue has been hanging around for over a year. @dhil?

I don't think there are any negative consequences.

@jamescheney jamescheney changed the title [WIP] attempt at one-line fix to #330 one-line fix to #330 Sep 1, 2019
@jamescheney jamescheney merged commit d834bf9 into master Sep 2, 2019
@jamescheney
Copy link
Contributor Author

Closes #330

@jamescheney jamescheney deleted the jrc-issue-330 branch June 28, 2020 13:09
frank-emrich pushed a commit to frank-emrich/links that referenced this pull request Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants