Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create SRV domain_record #548

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

yec-akamai
Copy link
Contributor

@yec-akamai yec-akamai commented Jul 22, 2024

📝 Description

Fix a bug that name is required together with type in the domain_record. For SRV domain record, service instead of name is used in domain record creation.

Addressed #521.

✔️ How to Test

make TEST_ARGS="-v domain_record" test

Manual test:

  1. In a sandbox environment, run the following script to create a domain and a SRV domain_record under it.
- name: test
  hosts: localhost
  tasks:
    - name: Create domain
      linode.cloud.domain:
        domain: 'host.example.com'
        soa_email: 'realemail@example.com'
        type: 'master'
        state: present
      register: domain_create

    - name: Create an SRV domain record
      linode.cloud.domain_record:
        domain: '{{ domain_create.domain.domain }}'
        service: carddavs
        protocol: tcp
        type: 'SRV'
        target: host.example.com
        port: 443
        priority: 0
        weight: 1
        state: present
  1. Observe that the domain_record is created successfully

@yec-akamai yec-akamai added the bugfix for any bug fixes in the changelog. label Jul 22, 2024
@yec-akamai yec-akamai requested a review from a team as a code owner July 22, 2024 16:31
@yec-akamai yec-akamai requested review from zliang-akamai and ykim-1 and removed request for a team July 22, 2024 16:31
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well to me. Nice work!

Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@yec-akamai yec-akamai merged commit d1753c0 into linode:dev Jul 26, 2024
4 checks passed
@yec-akamai yec-akamai deleted the TPT-3003/fix-domain-record branch July 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix for any bug fixes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants