try to get nodebalancers by IP before hostname

linode · Mar 5, 2021 · 4bbf096 · 4bbf096
1 parent 262d789
commit 4bbf096
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cloud/linode/loadbalancers.go b/cloud/linode/loadbalancers.go
@@ -124,12 +124,12 @@ func (l *loadbalancers) getLatestServiceLoadBalancerStatus(ctx context.Context,
 // most recent LoadBalancer status.
 func (l *loadbalancers) getNodeBalancerByStatus(ctx context.Context, service *v1.Service) (nb *linodego.NodeBalancer, err error) {
 	for _, ingress := range service.Status.LoadBalancer.Ingress {
-		if ingress.Hostname != "" {
-			return l.getNodeBalancerByHostname(ctx, service, ingress.Hostname)
-		}
 		if ingress.IP != "" {
 			return l.getNodeBalancerByIPv4(ctx, service, ingress.IP)
 		}
+		if ingress.Hostname != "" {
+			return l.getNodeBalancerByHostname(ctx, service, ingress.Hostname)
+		}
 	}
 	return nil, lbNotFoundError{serviceNn: getServiceNn(service)}
 }