Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-port configs via annotations #84

Closed
quidquid opened this issue Nov 24, 2020 · 1 comment · Fixed by #86
Closed

Per-port configs via annotations #84

quidquid opened this issue Nov 24, 2020 · 1 comment · Fixed by #86
Assignees

Comments

@quidquid
Copy link

The annotations are very useful to configure NodeBalancer options, thank you. It appears the only port-specific options are for protocol and TLS cert, and the rest apply globally to the balancer on every port configuration.

It would be helpful to define options on a per-port basis, the way they're arranged in the Cloud Manager. For example, different services have different compatibility with proxy-protocol, and might have different health check requirements. I'm using Traefik for ingress, and as more non-HTTP services are added as entrypoints, ports are added to the same LoadBalancer resource yet it becomes unreasonable to apply the same NB config to all equally.

One route might be to allow the linode-loadbalancer-port-* JSON entries to contain other annotation key/value pairs, which merge into and override the global values before being passed to the underlying NodeBalancer API for that port-config. Does that make sense?

Thanks!

@phillc
Copy link
Contributor

phillc commented Nov 24, 2020

Hello,

Your request does indeed make sense. I will add it to our internal tracker. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants