Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuring proxy-protocol per port #86

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

0xch4z
Copy link
Contributor

@0xch4z 0xch4z commented Dec 9, 2020

Closes #84.

These changes add a proxy-protocol field to the port-* annotation and deprecate the proxy-protocol annotation in favor of default-proxy-protocol. The deprecated annotation will be removed in Q4 of 2021.

e2e/test/ccm_e2e_test.go Show resolved Hide resolved
e2e/test/ccm_e2e_test.go Show resolved Hide resolved
Copy link
Contributor

@sibucan sibucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some changes, as I noticed a weird bug when testing. I did suggest a fix, however:

cloud/linode/loadbalancers.go Outdated Show resolved Hide resolved
cloud/linode/loadbalancers.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@0xch4z 0xch4z force-pushed the feat/nodebal-per-port-config branch from b2f21b4 to 3420b69 Compare December 30, 2020 21:32
@0xch4z 0xch4z requested review from sibucan and removed request for asauber December 30, 2020 21:34
@0xch4z 0xch4z merged commit a0465bd into linode:master Jan 7, 2021
@quidquid
Copy link

quidquid commented Jan 7, 2021

Very cool, thank you for working on this! 😁

@quidquid
Copy link

Sorry to bother again -- I tried the new annotations (default and per-port proxy-protocol) on my LoadBalancer Service this weekend and didn't see them having an effect on the existing NodeBalancer. Only the old linode-loadbalancer-proxy-protocol annotation applies the change for me. I see they're written up in the live readme though -- is there a release schedule planned, or any update I'd need to do in my own configs? (I'm using LKE with a 1.18.8 cluster). I set these annotations & see they're present in the k8s Service object, basically what's in the readme example AFAICT:

    service.beta.kubernetes.io/linode-loadbalancer-default-proxy-protocol: v2
    service.beta.kubernetes.io/linode-loadbalancer-port-1194: |
      {
        "proxy-protocol": "none"
      }

@phillc
Copy link
Contributor

phillc commented Jan 11, 2021

Hello,

The changes take a little longer to make it to LKE. Until that is released, you will need to use the deprecated annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-port configs via annotations
4 participants