-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow configuring proxy-protocol per port #86
Conversation
ca215e3
to
b2f21b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some changes, as I noticed a weird bug when testing. I did suggest a fix, however:
b2f21b4
to
3420b69
Compare
Very cool, thank you for working on this! 😁 |
Sorry to bother again -- I tried the new annotations (default and per-port proxy-protocol) on my LoadBalancer Service this weekend and didn't see them having an effect on the existing NodeBalancer. Only the old
|
Hello, The changes take a little longer to make it to LKE. Until that is released, you will need to use the deprecated annotation. |
Closes #84.
These changes add a
proxy-protocol
field to theport-*
annotation and deprecate theproxy-protocol
annotation in favor ofdefault-proxy-protocol
. The deprecated annotation will be removed in Q4 of 2021.