-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme #15
Update Readme #15
Conversation
Then, to run the image | ||
```bash | ||
$ docker run -ti linode/linode-cloud-controller-manager:canary | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the following standard sections:
Contribution Guidelines
Want to improve the linode-cloud-controller-manager? Please start here.
Join us on Slack
For general help or discussion, join the Kubernetes Slack channel #linode.
For development and debugging, join the Gopher's Slack channel #linodego.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those sections exist already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind having them appear at the bottom of the readme, in keeping with our other repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that makes sense. Keep the main content repo-specific.
README.md
Outdated
## Development Guide | ||
|
||
This document is intended to be the canonical source of truth for things like | ||
supported toolchain versions for building the Linode Cloud Controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this paragraph needed? Seems like these are understood and might not need to be spelled out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, removed them
@asauber changes approved. Nice work here :) |
Thanks @sarahelizgray, merging |
No description provided.