Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme #15

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Update Readme #15

merged 1 commit into from
Jan 7, 2019

Conversation

asauber
Copy link
Contributor

@asauber asauber commented Jan 3, 2019

No description provided.

Then, to run the image
```bash
$ docker run -ti linode/linode-cloud-controller-manager:canary
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the following standard sections:

Contribution Guidelines

Want to improve the linode-cloud-controller-manager? Please start here.

Join us on Slack

For general help or discussion, join the Kubernetes Slack channel #linode.

For development and debugging, join the Gopher's Slack channel #linodego.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those sections exist already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind having them appear at the bottom of the readme, in keeping with our other repos?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that makes sense. Keep the main content repo-specific.

README.md Outdated
## Development Guide

This document is intended to be the canonical source of truth for things like
supported toolchain versions for building the Linode Cloud Controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this paragraph needed? Seems like these are understood and might not need to be spelled out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, removed them

@sarahelizgray
Copy link
Contributor

@asauber changes approved. Nice work here :)

@asauber
Copy link
Contributor Author

asauber commented Jan 7, 2019

Thanks @sarahelizgray, merging

@asauber asauber merged commit 31a9d49 into linode:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants