don't error out with empty vpc name if routecontroller is disabled #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
luthermonson
approved these changes
Mar 14, 2024
luthermonson
pushed a commit
that referenced
this pull request
Mar 14, 2024
) (#191) Co-authored-by: Rahul Sharma <rahsharm@akamai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General:
We added route_controller to linode ccm. It is disabled by default and enabled when specific flags are specified. We ended up introducing a bug where if its disabled by default, it keeps crashing as it tries to check for VPC info which it shouldn't care if route_controller is disabled. This PR fixes it.
Pull Request Guidelines: