-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lookup linode by IP instead if label or providerID do not match #198
Conversation
one outstanding question here is do we need to be worried about collisions with linode private IPs possibly being the same with customer linodes in different DCs? perhaps we need to restrict it to just the public IP of the linode? |
Co-authored-by: Alex Vest <avestuk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me. We might have to rebase again as we merged other PR to main.
General:
This change adds a
lookupByIP
function if a linode cannot be found by label or ID. This means rather that as long as the node and linode share an IP address it will be able to lookup the linode. additionally, we now set the ProviderID based on this lookup if it is not already set so future lookups only need to be made against the ID.Pull Request Guidelines: