Port annotation #39
Closed
Port annotation #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillc
force-pushed
the
port-annotation
branch
from
3256bb5
to
d40d026
Compare
- One run took over an hour because of the same failure in multiple tests. 2 minutes was too little for some cases.
phillc
force-pushed
the
port-annotation
branch
from
5d4cbf3
to
e2cebef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New port annotation.
Fixes issues with the former protocol annotation where specifying https would not allow for an http port to be opened, as the node balancer creation would fail.