Added KubeconfigFlag option based on CCM --kubeconfig flag #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When explicitly passing a kubeconfig via --kubeconfig, the CCM would use the provided kubeconfig but Linode-specific logic would not. This would lead to errors when attempting to use a Kubernetes client to get TLS secrets, as the CCM was attempting to get those from the cluster it was in as opposed to the cluster it was pointing to based on the given kubeconfig. This addresses that issue by defining and setting a KubeconfigFlag option in linode.Options, then using that when creating a Kubernetes client. The presence of the flag in the flag set is required, but its use is not; if --kubeconfig is not set, the CCM will default to authenticating using the in-cluster config.
jnschaeffer
changed the title
asauber
reviewed
Nov 5, 2019
asauber
reviewed
Nov 5, 2019
asauber
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When explicitly passing a kubeconfig via --kubeconfig, the CCM would use the provided kubeconfig but Linode-specific logic would not. This would lead to errors when attempting to use a Kubernetes client to get TLS secrets, as the CCM was attempting to get those from the cluster it was in as opposed to the cluster it was pointing to based on the given kubeconfig.
This addresses that issue by defining and setting a KubeconfigFlag option in linode.Options, then using that when creating a Kubernetes client. The presence of the flag in the flag set is required, but its use is not; if --kubeconfig is not set, the CCM will default to authenticating using the in-cluster config.
I'm pretty sure this works, but still need to test it 馃懠 Placing it here now for review.