Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/go-resty/resty/v2 from 2.1.1-0.20191201195748-d7b97669fe48 to 2.7.0 #303

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 24, 2023

Bumps github.com/go-resty/resty/v2 from 2.1.1-0.20191201195748-d7b97669fe48 to 2.7.0.

Release notes

Sourced from github.com/go-resty/resty/v2's releases.

v2.7.0 Release

Release Notes

Enhancements

Bug Fixes

Tests

  • Add 1.16.x and remove 1.14.x from the Travis build PR #434 @​kishaningithub
  • Migrated from Travis CI to Github Actions #479 PR #480 @​jeevatkm
    • Thank you Travis CI for these many years of CI service to Resty project

Documentation

v2.6.0 Release

Release Notes

Features

Enhancements

General

  • Addressing checksum issue on v2.5.0 with this release

v2.5.0 Release

Release Notes

Bug Fixes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@lgarber-akamai lgarber-akamai requested review from a team and removed request for a team March 1, 2023 16:02
@lgarber-akamai
Copy link
Contributor

Looks like we'll have to hold off on this one for a bit due to some weird endpoint function failures.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 1, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/go-resty/resty/v2-2.7.0 branch March 1, 2023 16:11
@zliang-akamai
Copy link
Member

@lgarber-akamai Can we keep the PR open and resolve the issue once we got a chance?

@zliang-akamai
Copy link
Member

@dependabot reopen

@dependabot dependabot bot reopened this Mar 1, 2023
@dependabot dependabot bot restored the dependabot/go_modules/github.com/go-resty/resty/v2-2.7.0 branch March 1, 2023 16:46
@zliang-akamai zliang-akamai self-requested a review March 1, 2023 16:47
@zliang-akamai
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 2, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@zliang-akamai
Copy link
Member

@dependabot recreate

Bumps [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) from 2.1.1-0.20191201195748-d7b97669fe48 to 2.7.0.
- [Release notes](https://github.com/go-resty/resty/releases)
- [Commits](https://github.com/go-resty/resty/commits/v2.7.0)

---
updated-dependencies:
- dependency-name: github.com/go-resty/resty/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-resty/resty/v2-2.7.0 branch from ad5a0ad to 14ce23f Compare March 2, 2023 16:18
@zliang-akamai
Copy link
Member

The error is related to a resty issue that 1 ns max timeout can cause an error. Posted it on their GitHub issues. On our side, we can modify the max retry from 1 nanosecond to 1 microsecond to solve it.

go-resty/resty#624

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zliang-akamai Nice find!

@zliang-akamai zliang-akamai merged commit d063400 into main Mar 2, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/go-resty/resty/v2-2.7.0 branch March 2, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants