-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7665] - RegionMultiSelect Component #10084
Conversation
Coverage Report: β
|
packages/manager/src/components/RegionSelect/RegionMultiSelect.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/RegionSelect/RegionMultiSelect.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/RegionSelect/RegionMultiSelect.tsx
Outdated
Show resolved
Hide resolved
The dark mode background colors/shading is a little weird. Do we also want to have a border under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for breaking this down in its own component!
The component tested in Storybook looks good π
Left a couple questions and some comments to improve code
Also, I am not a fan of this UI pattern in general. When selecting a region, the user has no idea a list is behind the dropdown, and the checkmark next to the region is faint. There's a risk the user does not know the selection worked. I'd like to bring this to UX cause we may want to re-thing this pattern. CC @jaalah-akamai
packages/manager/src/components/RegionSelect/RegionMultiSelect.stories.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/RegionSelect/RegionMultiSelect.stories.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/RegionSelect/RegionMultiSelect.stories.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/RegionSelect/RegionMultiSelect.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/RegionSelect/RegionMultiSelect.tsx
Outdated
Show resolved
Hide resolved
@jaalah-akamai @jaalah-akamai Great feedback.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! - a couple more comments to clean things up and this should be good to go
packages/manager/src/components/RegionSelect/RegionMultiSelect.stories.tsx
Outdated
Show resolved
Hide resolved
β¦.stories.tsx Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for re-using RegionOption, much better. I'm sure there's more we can do, but this is good for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One day, we may want to combine RegionSelect and RegionMultiSelect into one component, but this is good for now!
Description π
This Allows to select multiple regions and renders the list of selected regions
Changes π
Preview π·
How to test π§ͺ
As an Author I have considered π€
Check all that apply