Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7699] - Put newly created ACLB Rules at the top of the table upon creation #10107

Conversation

bnussman-akamai
Copy link
Contributor

@bnussman-akamai bnussman-akamai commented Jan 24, 2024

Description πŸ“

  • Puts ACLB rules at the top of the table / array when the rule is created

Preview πŸ“·

Before After
Screen.Recording.2024-01-24.at.5.29.08.PM.mov
Screen.Recording.2024-01-24.at.5.27.59.PM.mov

How to test πŸ§ͺ

Prerequisites

  • Have the AGLB flag on
  • Use the dev environment
  • Login to the dev-test-aglb account

Verification steps

  • Verify that when you create a new rule, it is placed at the top of the rules table.

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@bnussman-akamai bnussman-akamai added Ready for Review ACLB Relating to the Akamai Cloud Load Balancer labels Jan 24, 2024
@bnussman-akamai bnussman-akamai self-assigned this Jan 24, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner January 24, 2024 22:32
@bnussman-akamai bnussman-akamai requested review from hana-linode and cpathipa and removed request for a team January 24, 2024 22:32
Copy link

github-actions bot commented Jan 24, 2024

Coverage Report: βœ…
Base Coverage: 80.33%
Current Coverage: 80.33%

@hana-linode hana-linode changed the title upcoming: [M3-7539] - Put newly created ACLB Rules at the top of the table upon creation upcoming: [M3-7699] - Put newly created ACLB Rules at the top of the table upon creation Jan 25, 2024
Copy link
Contributor

@hana-linode hana-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New rules are placed at the top of the rules table βœ…

@hana-linode hana-linode added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Jan 25, 2024
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified new rule is placed at the top of the rules table.

@cpathipa cpathipa added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 29, 2024
@bnussman-akamai bnussman-akamai merged commit 2008880 into linode:develop Jan 29, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants