Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-7710] - Table Collapsible row icon orientation #10119

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Jan 29, 2024

Description πŸ“

Small PR to rectify the orientation of the Collapsible TableRow icon

Preview πŸ“·

Before (closed) After (closed)
localhost_3000_vpcs_19662 (2) localhost_3000_vpcs_19662
Before (open) After (open)
localhost_3000_vpcs_19662 (3) localhost_3000_vpcs_19662 (1)

How to test πŸ§ͺ

Prerequisites

  • Have a VPC and subnet

Reproduction steps

Verification steps

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Jan 29, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review January 29, 2024 17:37
@abailly-akamai abailly-akamai requested a review from a team as a code owner January 29, 2024 17:37
@abailly-akamai abailly-akamai requested review from jdamore-linode and hkhalil-akamai and removed request for a team January 29, 2024 17:37
Copy link

github-actions bot commented Jan 29, 2024

Coverage Report: βœ…
Base Coverage: 81.21%
Current Coverage: 81.21%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this - looks much better!

Screen.Recording.2024-01-29.at.1.56.17.PM.mov

In addition to VPC, the collapsible table is also used in ACLB routes and there's an integration test failing because of the aria-label change. Approving pending that quick fix.

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jan 29, 2024
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Approved pending CI fixes

@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 30, 2024
@abailly-akamai abailly-akamai requested a review from a team as a code owner January 30, 2024 14:29
@abailly-akamai abailly-akamai requested review from cliu-akamai and removed request for a team January 30, 2024 14:29
Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think I like this better too.

@abailly-akamai abailly-akamai merged commit 9781197 into linode:develop Jan 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants