change: [M3-7715] - Remove kubernetesDashboardAvailability feature flag
#10121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
LKE
bnussman-akamai
requested review from
mjac0bs and
jaalah-akamai
and removed request for
a team
bnussman-akamai
changed the title
kubernetesDashboardAvailability feature flagkubernetesDashboardAvailability feature flag
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
It's always exciting to see feature flag clean up, thanks for doing it! Confirmed the Dashboard Availability link is still present and opens after the un-flagging. (And I turned the flag off in the dev environment in LD.)
Wondering if we should make a note in the release testing doc to archive the flag in LD completely post-release. The final LD clean up is easy to forget sometimes.
As tempting as it is, this PR does not attempt to fix how broken this summary section is.
I know, it's hard. 😅
jdamore-linode
approved these changes
Jan 29, 2024
bnussman-akamai
added
Approved
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Just doing some feature flag clean up. The Kubernetes Dashboard feature has been in production for at least a year or two. I think we can safely clean up this flag! 🧹
As tempting as it is, this PR does not attempt to fix how broken this summary section is.
Preview 📷
Note
This should not result in UI changes. This feature has been enabled for a long time and should remain enabled.
How to test 🧪
Kubernetes Dashboardbutton on the Kubernetes Details page on any LKE clusterAs an Author I have considered 🤔