Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-7720] - Refactor AccessKeyTable - Eliminate react anti patterns #10124

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Jan 30, 2024

Description πŸ“

  • Refactors Object-Storage - AccessKeyTable component.
  • Eliminates react anti patterns like calling functions that render JSX.
  • No Visual changes.

How to test πŸ§ͺ

(How to verify changes)

  • Validate Object storage Access key flow - create/update/revoke.
  • Validate the Access Key landing page and ensure there are no regressions in the Access Key flow.

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@cpathipa cpathipa requested a review from a team as a code owner January 30, 2024 15:43
@cpathipa cpathipa requested review from carrillo-erik and abailly-akamai and removed request for a team January 30, 2024 15:43
@cpathipa cpathipa marked this pull request as draft January 30, 2024 15:43
@cpathipa cpathipa marked this pull request as ready for review January 30, 2024 15:48
@cpathipa cpathipa self-assigned this Jan 30, 2024
Copy link

github-actions bot commented Jan 30, 2024

Coverage Report: βœ…
Base Coverage: 81.15%
Current Coverage: 81.15%

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Jan 30, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we fix this markup error as well?

Screenshot 2024-01-30 at 15 29 29

@abailly-akamai
Copy link
Contributor

@cpathipa /object-storage/access-keys is crashing with the OBJ Multi-Cluster flag on

@carrillo-erik
Copy link
Contributor

I was able to verify that I can create/update/revoke access keys after the changes. One thing I also noticed was that there are associated events with the actions I've mentioned, however, we do not show any toast notifications.

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 31, 2024
@cpathipa cpathipa merged commit ae7f8a1 into linode:develop Jan 31, 2024
17 of 18 checks passed
@cpathipa cpathipa deleted the M3-7720 branch January 31, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants