-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7366] - Improved Primary Navigation UX #10137
Conversation
Coverage Report: ✅ |
dc920c1
to
9faa348
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaalah-akamai heads up i rebased the PR
I think we still need to handle the vertical centering of both the logo and the managed menu item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnussman-akamai that's a great suggestion - let's go blue! @jaalah-akamai? |
As an alum, I couldn't resist this one opportunity. 😆 |
@bnussman-akamai @abailly-akamai @mjac0bs UX wants to hold on the color change especially since we'll be introducing design tokens soon and the colors will shift slightly. It's on our radar though! |
This is good to go otherwise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great on Chrome, Safari, and Firefox at various breakpoints. 🚀
The only thought I had (and perhaps only because I was sitting there clicking this button repeatedly), is that the fade out of the text feels a little slow when collapsing the menu.
Screen.Recording.2024-03-27.at.9.29.04.AM.mov
"@linode/manager": Tech Stories | ||
--- | ||
|
||
Improved Primary Navigation UX ([#10137](https://github.com/linode/manager/pull/10137)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved Primary Navigation UX ([#10137](https://github.com/linode/manager/pull/10137)) | |
Improve Primary Navigation UX ([#10137](https://github.com/linode/manager/pull/10137)) |
Nit: present tense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's by design so that the border lines up with the top menu |
Description 📝
Overall improvements to primary nav, which includes changes to accommodate longer Cloud Manager feature names.
Changes 🔄
Screenshot
How to test 🧪