upcoming: [M3-7726] - Assign Linodes to Placement Group Drawer #10140

abailly-akamai · 2024-02-01T21:14:59Z

Description 📝

This PR brings the drawer to assign linodes to a PG (in the VPC subnet fashion) + improvements and naming convention updates

Changes 🔄

Add new drawer and tests
Connect drawer to flow
Update utils and function names to use "linode" instead of "vm"
Small (non breaking) updates to the RemovableSelectionList to allow for extra styling and accessibility improvements

Preview 📷

How to test 🧪

Prerequisites

Turn on both the "Placement Groups" feature flag and MSW

Verification steps

Navigate to /placement-groups/1/linodes
Click on "Add Linode to Placement Group"
Confirm
- overall form behavior
- adding/removing a linode from the list (and invalidation)

NOTE: due to limitations in using MSW, we can only really see adding/removing ONE linode at a time (subsequent tries won't be reflected in the UI)

As an Author I have considered 🤔

Check all that apply

abailly-akamai · 2024-02-07T16:10:02Z

packages/api-v4/src/placement-groups/placement-groups.ts

  CreatePlacementGroupPayload,
  PlacementGroup,
-  UnassignVMsFromPlacementGroupPayload,
+  UnassignLinodesFromPlacementGroupPayload,


I've updated utils to read "linode(s)" instead of "VM(s)" for consistency since VM is more of of product name and linode is more clear in code

abailly-akamai · 2024-02-07T16:11:02Z

packages/manager/src/components/RemovableSelectionsList/RemovableSelectionsList.tsx

+  /**
+   * Additional styles to apply to the component
+   */
+  sx?: SxProps<Theme>;


Improving the RemovableSelectionList to make it a tad more flexible

abailly-akamai · 2024-02-07T17:59:38Z

packages/validation/src/placement-groups.schema.ts

-
-export const unassignVMsFromPlacementGroupSchema = object({
-  linodeIds: array().of(number().max(1, 'Only one Linode id is supported.')),
-});


We don't really need those schemas cause we're using a drawer that does requests outside of a regular formik/form schema. We still have validation, but we don't need a schema for the one field

abailly-akamai · 2024-02-07T18:00:03Z

packages/manager/src/queries/placementGroups.ts

+        'linode',
+        updatedPlacementGroup.linode_ids[0],
+        'placement_groups',
+      ]);


adding more granularity to our invalidations

github-actions · 2024-02-07T19:09:42Z

Coverage Report: ✅
Base Coverage: 81.12%
Current Coverage: 81.13%

packages/api-v4/src/placement-groups/placement-groups.ts

jaalah-akamai

Looks good overall, just confirming warning is expected?

Also, will this have it's own permissions/grant like add_placement_groups or something?

jaalah-akamai · 2024-02-08T17:52:36Z

packages/manager/src/features/PlacementGroups/utils.ts

+    return [...acc, ...placementGroup.linode_ids];
+  }, []);
+
+  return Array.from(new Set(linodeIds));


packages/manager/src/features/PlacementGroups/PlacementGroupsAssignLinodesDrawer.tsx

abailly-akamai · 2024-02-08T20:36:02Z

@jaalah-akamai yes the banner is expected - i intentionally made it appear with our mocks upon reaching the 10 limit in the drawer

Also, will this have it's own permissions/grant like add_placement_groups or something?

So the permissions are the same as the Linode permissions per the API specs. Not sure what the approach should be. We have a separate ticket to handle those

packages/manager/src/features/PlacementGroups/PlacementGroupsAssignLinodesDrawer.tsx

hana-linode

Verified form behavior and adding/removing a Linode from the Placement Group

abailly-akamai self-assigned this Feb 1, 2024

abailly-akamai added Work in Progress Placement Groups labels Feb 1, 2024

abailly-akamai force-pushed the M3-7726 branch 2 times, most recently from aef2fe6 to f32a472 Compare February 7, 2024 15:51

abailly-akamai commented Feb 7, 2024

View reviewed changes

abailly-akamai marked this pull request as ready for review February 7, 2024 18:46

abailly-akamai requested a review from a team as a code owner February 7, 2024 18:46

abailly-akamai requested review from jdamore-linode, hana-linode and carrillo-erik and removed request for a team February 7, 2024 18:46

abailly-akamai removed the Work in Progress label Feb 7, 2024

jaalah-akamai reviewed Feb 7, 2024

View reviewed changes

packages/api-v4/src/placement-groups/placement-groups.ts Outdated Show resolved Hide resolved

packages/api-v4/src/placement-groups/placement-groups.ts Outdated Show resolved Hide resolved

abailly-akamai added 15 commits February 8, 2024 10:44

Improve add IP drawer

35dccda

Initial commit - save work

f5a1418

Post rebase fixes

78681a8

Cleanup and sorting improvements

2b28917

Cleanup and sorting improvements

7a02ee0

Adding unit tests

0cf5b2d

Cleanup

d48e8bd

Added changeset: Placement GroupLinode List

5198128

Save progress

ea022ed

Save progress

d8567bb

Save progress

a6dcd27

saving work

65cb23f

wrap up

ffc027d

Cleanup and tests

dfde78b

Post rebase diff fix

4d60040

abailly-akamai added 4 commits February 8, 2024 10:45

Text fix and cleanup

39c6bf4

Better querying

e89bbe0

Added changeset: Add AssignLinodesToPlacementGroup drawer

d1fdc5a

Better test

d75f5f6

abailly-akamai force-pushed the M3-7726 branch from 8fb5179 to d75f5f6 Compare February 8, 2024 15:45

Fix typo

8ca63f2

jaalah-akamai approved these changes Feb 8, 2024

View reviewed changes

hana-linode reviewed Feb 8, 2024

View reviewed changes

Feedback

b1a1d10

jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Feb 9, 2024

abailly-akamai requested a review from hana-linode February 9, 2024 15:04

bnussman-akamai reviewed Feb 9, 2024

View reviewed changes

packages/manager/src/features/PlacementGroups/PlacementGroupsAssignLinodesDrawer.tsx Outdated Show resolved Hide resolved

Ooops await

e081339

hana-linode approved these changes Feb 9, 2024

View reviewed changes

hana-linode added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Feb 9, 2024

abailly-akamai merged commit ebc3f76 into linode:develop Feb 9, 2024
18 checks passed

cpathipa mentioned this pull request Feb 12, 2024

Release v1.112.0 - release → staging #10174

Closed

This was referenced Feb 20, 2024

Release v1.113.0 - release → staging #10206

Merged

Release v1.113.0 – staging → master #10209

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming: [M3-7726] - Assign Linodes to Placement Group Drawer #10140

upcoming: [M3-7726] - Assign Linodes to Placement Group Drawer #10140

abailly-akamai commented Feb 1, 2024 •

edited

abailly-akamai Feb 7, 2024

abailly-akamai Feb 7, 2024

abailly-akamai Feb 7, 2024

abailly-akamai Feb 7, 2024

github-actions bot commented Feb 7, 2024 •

edited

jaalah-akamai left a comment

jaalah-akamai Feb 8, 2024

abailly-akamai commented Feb 8, 2024 •

edited

hana-linode left a comment

upcoming: [M3-7726] - Assign Linodes to Placement Group Drawer #10140

upcoming: [M3-7726] - Assign Linodes to Placement Group Drawer #10140

Conversation

abailly-akamai commented Feb 1, 2024 • edited

Description 📝

Changes 🔄

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

abailly-akamai Feb 7, 2024

Choose a reason for hiding this comment

abailly-akamai Feb 7, 2024

Choose a reason for hiding this comment

abailly-akamai Feb 7, 2024

Choose a reason for hiding this comment

abailly-akamai Feb 7, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 7, 2024 • edited

jaalah-akamai left a comment

Choose a reason for hiding this comment

jaalah-akamai Feb 8, 2024

Choose a reason for hiding this comment

abailly-akamai commented Feb 8, 2024 • edited

hana-linode left a comment

Choose a reason for hiding this comment

abailly-akamai commented Feb 1, 2024 •

edited

github-actions bot commented Feb 7, 2024 •

edited

abailly-akamai commented Feb 8, 2024 •

edited