Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-7736] - Clean up regionDropdown feature flag #10148

Conversation

bnussman-akamai
Copy link
Contributor

@bnussman-akamai bnussman-akamai commented Feb 6, 2024

Description πŸ“

In production, regionDropdown has been enabled for the last two years and has not changed. I think we can safely remove this flag from the codebase. 🧹

Preview πŸ“·

How to test πŸ§ͺ

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Feb 6, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner February 6, 2024 14:50
@bnussman-akamai bnussman-akamai requested review from jdamore-linode and hana-linode and removed request for a team February 6, 2024 14:50
@bnussman-akamai bnussman-akamai changed the title refactor: [M3-7736] - Remove regionDropdown feature flag refactor: [M3-7736] - Clean up regionDropdown feature flag Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Coverage Report: βœ…
Base Coverage: 81.18%
Current Coverage: 81.18%

@bnussman-akamai
Copy link
Contributor Author

billing/billing-contact.spec.ts failure is related to parent child. This PR should be okay!

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! Confirming the behavior is unchanged βœ…

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields are still required, functionality unchanged. 🚒 🧹

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Feb 6, 2024
@bnussman-akamai bnussman-akamai merged commit c80abf4 into linode:develop Feb 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Clean Up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants