change: [M3-7584] - Update react-router-dom in preparation for React 18
#10154
Conversation
bnussman-akamai
added
Dependencies
bnussman-akamai
requested review from
cpathipa and
hkhalil-akamai
and removed request for
a team
| * @example "/profile/display" | ||
| * @example "https://linode.com" | ||
| */ | ||
| to: string; |
There was a problem hiding this comment.
@abailly-akamai Curious to see what you think about this because you most recently revamped this component.
We could write some logic to handle all cases of to: H.LocationDescriptor<S> | ((location: H.Location<S>) => H.LocationDescriptor<S>), but I think this might be a more desirable approach for now.
There was a problem hiding this comment.
I agree - it matches our current linking conventions and url matching so unless we have a need to pass anything else am happy to keep it overridden for strings only
|
Coverage Report: ✅ |
bnussman-akamai
added
Add'tl Approval Needed
| * @example "/profile/display" | ||
| * @example "https://linode.com" | ||
| */ | ||
| to: string; |
There was a problem hiding this comment.
I agree - it matches our current linking conventions and url matching so unless we have a need to pass anything else am happy to keep it overridden for strings only
bnussman-akamai
added
Approved
Description 📝
Updates
react-router-dom(and its types) to the latest v5 version for React 18 compatibility 📦This should get us one step closer to React 18
How to test 🧪
As an Author I have considered 🤔