refactor: [M3-7582] - Remove Enzyme #10160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
cpathipa and
hkhalil-akamai
and removed request for
a team
|
Coverage Report: ❌ |
bnussman-akamai
commented
Feb 7, 2024
| @@ -199,9 +195,11 @@ | |||
| "mocha-junit-reporter": "^2.2.1", | |||
| "msw": "~1.3.2", | |||
| "prettier": "~2.2.1", | |||
| "react-test-renderer": "16.14.0", | |||
There was a problem hiding this comment.
We have to explicitly define this now that enzyme is gone
If we don't install this, we'll get the following:
There was a problem hiding this comment.
My hope is that when we upgrade React Testing Library, we can remove this explicit definition.
There was a problem hiding this comment.
Thankfully, we don't use "Pagey" anywhere so I was able to remove all of this!
hkhalil-akamai
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Rip Pagey, whatever it was 🪦
Comment on lines
-175
to
-176
| "enzyme": "^3.10.0", | ||
| "enzyme-adapter-react-16": "^1.14.0", |
bnussman-akamai
added
Add'tl Approval Needed
abailly-akamai
approved these changes
Feb 8, 2024
bnussman-akamai
added
Approved
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Removing Enzyme in favor or React Testing Library has been in the works for years now. This PR's goal is to finally get Enzyme out of here 🗑️. We're really close, so I'm just going to do it all in one sweep with this PR. 🎉
Notes ✏️
How to test 🧪
As an Author I have considered 🤔