test: [M3-7452] - Add Cypress test to check empty state in Images landing page #10167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliu-akamai
requested review from
jdamore-linode
and removed request for
a team
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Feb 13, 2024
| import { mockGetAllImages } from 'support/intercepts/images'; | ||
| import { authenticate } from 'support/api/authentication'; | ||
|
|
||
| authenticate(); |
There was a problem hiding this comment.
Do we need this call to authenticate()? Based on my understanding, we don't since we're mocking the request to GET images, not using a real API request, and since other similar empty landing page specs don't use it.
There was a problem hiding this comment.
@mjac0bs That's right -- authenticate() is only necessary when we're making real API requests from inside the tests, so it's not needed here 👍
jdamore-linode
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Nice work @cliu-akamai! Approved pending the things Mariah mentioned:
- Remove call to
authenticate()and related import - Add a changeset
jdamore-linode
added
Approved
cliu-akamai
force-pushed
the
feature/M3-7452
branch
from
631578b
to
3318a76
Compare
cliu-akamai
requested review from
hana-linode and
carrillo-erik
and removed request for
a team
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add regression tests to check Images landing page empty state.
Major Changes 🔄
How to test 🧪