Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [M3-7754] - fix bundle analyse script #10175

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Feb 12, 2024

Description πŸ“

I assume the script was broken since the vite update. This small PR makes it available again via vite-bunder-visualizer

Changes πŸ”„

  • fix broken bundle analyzer script in package.json

Preview πŸ“·

Screenshot 2024-02-12 at 10 22 19

How to test πŸ§ͺ

Reproduction steps

  • from the root, run yarn build:analyze
  • see failure

Verification steps

(How to verify changes)

  • from the root, run yarn build:analyze
  • confirm report opening in the browser

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Feb 12, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review February 12, 2024 15:26
@abailly-akamai abailly-akamai requested a review from a team as a code owner February 12, 2024 15:26
@abailly-akamai abailly-akamai requested review from jdamore-linode and mjac0bs and removed request for a team February 12, 2024 15:26
Copy link

github-actions bot commented Feb 12, 2024

Coverage Report: βœ…
Base Coverage: 81.13%
Current Coverage: 81.13%

Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -85,6 +85,7 @@
"start:ci": "yarn serve ./build -p 3000 -s --cors",
"lint": "yarn run eslint . --ext .js,.ts,.tsx --quiet",
"build": "node scripts/prebuild.mjs && vite build",
"build:analyze": "npx vite-bundle-visualizer",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Use bunx if we're feeling crazy πŸ€ͺ

Suggested change
"build:analyze": "npx vite-bundle-visualizer",
"build:analyze": "bunx vite-bundle-visualizer",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you got it πŸ‘

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

Screenshot 2024-02-12 at 9 50 21 AM

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Feb 12, 2024
@abailly-akamai abailly-akamai merged commit daf3828 into linode:develop Feb 12, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants