-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7753] - Tag custom analytics events for account switching #10190
upcoming: [M3-7753] - Tag custom analytics events for account switching #10190
Conversation
|
||
// AccountLanding.tsx | ||
// UserMenu.tsx | ||
export const sendSwitchAccountEvent = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sendSwitchAccountEvent
is going to get called whenever the Switch Account button is clicked, which means the analytics event will fire when a user clicks the button to open the drawer and switch back to parent account (which then fires sendSwitchToParentAccountEvent
) and when the user clicks the button in attempt to open the drawer and sees the session expiry modal.
I opted not to mention proxy
in the function name or category
out of concern that might be misleading since some of the times the event fires, users will not truly be switching to a proxy account, but doing something else. (But screenshots have not been updated since that change.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β Confirmed events for:
- Both Switch Account Buttons
- Expiry Dialog
- Return to parent link
@mjac0bs Is there another step required to set up the logging on the user's end? The code looks good to me and I can verify everything else other than the issue mentioned above. |
@carrillo-erik you'll need the env variable as well - i'll dm you |
Thanks @jaalah-akamai After I added the env variable, I can confirm the events are shown in the browser console logs. |
Coverage Report: β |
Thanks @jaalah-akamai - I'd forgotten about the env var. @carrillo-erik - we have a section on Adobe Analytics in our developer docs, in case that is helpful in the future. Merged in develop to address the merge conflict in |
Description π
For Parent/Child account switching flows, we want to keep track of:
Changes π
List any change relevant to the reviewer.
sendSwitchAccountEvent
,sendSwitchToParentAccountEvent
, andsendSwitchAccountSessionExpiryEvent
functions toanalytics.ts
and calls them when the corresponding button clicks are made.Preview π·
How to test π§ͺ
Prerequisites
(How to setup test environment)
yarn dev
_satellite.setDebug(true)
user_type
for*/profile
is"parent"
inserverHandlers.ts
Verification steps
(How to verify changes)
sendSwitchAccountEvent
has fired in the browser console log with labelAccount Landing
sendSwitchAccountEvent
has fired in the browser console log with labelUser Menu
user_type
for*/profile
to"proxy"
inserverHandlers.ts
sendSwitchToParentAccountEvent
has fired in the browser console logsendSwitchAccountSessionExpiryEvent
with the appropriate label. Note thatLog In
is tricky because the event will only be visible for a brief moment before the page redirects.As an Author I have considered π€
Check all that apply