Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [UIE-7292] - update scale-up to resize #10193

Conversation

mpolotsk-akamai
Copy link
Contributor

Description 📝

Updated "Scaled-Up" to "Resize"

Changes 🔄

Updated "Scaled-Up" to "Resize" within Scale Up tab in the Database Cluster

How to test 🧪

Open application, navigate to /databases, select the database cluster.
See that tab is now "Resize" instead of "Scale up". The text "scale up" and buttons name also changed to "resize" in this tab section

@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner February 14, 2024 16:47
@mpolotsk-akamai mpolotsk-akamai requested review from hana-linode and jaalah-akamai and removed request for a team February 14, 2024 16:47
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -85,7 +85,7 @@ export const PlanContainer = (props: Props) => {
// DC Dynamic price logic - DB creation and DB scale up flows are currently out of scope
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// DC Dynamic price logic - DB creation and DB scale up flows are currently out of scope
// DC Dynamic price logic - DB creation and DB resize flows are currently out of scope

@jaalah-akamai
Copy link
Contributor

Also don't forget to add a changeset yarn changeset

Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change 👏🏼

Will the API rename the database_scale Account Event to database_resize? I think this change should be made because this feature hasn't launched yet and we don't want to be stuck with this inconsistency for the rest of time

@mpolotsk-akamai mpolotsk-akamai force-pushed the feature/UIE-7292-scaled-up-to-resize branch from e172bc1 to 9707ab5 Compare February 16, 2024 13:06
@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Feb 17, 2024
@jaalah-akamai
Copy link
Contributor

We may need a changeset for the APIv4 package, same command as before

Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good!

Can we change file names like DatabaseScaleUp.tsx to DatabaseResize.tsx and also variables inside that file to use "Resize" instead of "ScaleUp".

Once we get this consistency, I think this PR will be good to go!

Copy link

github-actions bot commented Feb 20, 2024

Coverage Report:
Base Coverage: 81.33%
Current Coverage: 81.33%

@mpolotsk-akamai
Copy link
Contributor Author

@bnussman-akamai , DatabaseScaleUp.tsx and all variables related to "scale up" renamed to "resize"

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Missing Changeset labels Feb 23, 2024
Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for you addressing all of that feedback! All checks passed!

@bnussman-akamai bnussman-akamai merged commit c1457a8 into linode:develop Feb 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants