feat: [M3-7687] - Refactor & Improve LinodeActionMenu Restricted User Experience
#10199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
added
the
Restricted User Access
jaalah-akamai
commented
Feb 15, 2024
| onClick: handlePowerAction, | ||
| title: linodeStatus === 'running' ? 'Power Off' : 'Power On', | ||
| tooltipAction: 'modify', | ||
| }, |
There was a problem hiding this comment.
Overall, I went with this config approach to remove some of the redundancies in the original. Open for discussion.
jaalah-akamai
changed the title
LinodeActionMenu Restricted User Experience
jaalah-akamai
requested review from
cpathipa and
hkhalil-akamai
and removed request for
a team
|
Coverage Report: ✅ |
hkhalil-akamai
approved these changes
Feb 16, 2024
packages/manager/src/features/Linodes/LinodesLanding/LinodeActionMenu/LinodeActionMenu.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesLanding/LinodeActionMenu/LinodeActionMenu.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesLanding/LinodeActionMenu/LinodeActionMenu.tsx
Outdated
Show resolved
Hide resolved
...s/manager/src/features/Linodes/LinodesLanding/LinodeActionMenu/useLinodeActionVisibility.tsx
Outdated
Show resolved
Hide resolved
…ionMenu/LinodeActionMenu.test.tsx Co-authored-by: Hussain Khalil <122488130+hkhalil-akamai@users.noreply.github.com>
…ionMenu/LinodeActionMenu.test.tsx Co-authored-by: Hussain Khalil <122488130+hkhalil-akamai@users.noreply.github.com>
packages/manager/src/features/Linodes/LinodesLanding/LinodeActionMenu/LinodeActionMenu.tsx
Outdated
Show resolved
Hide resolved
|
Thanks @bnussman-akamai |
bnussman-akamai
approved these changes
Feb 20, 2024
bnussman-akamai
added
Approved
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
There's more work to do for Linodes to improve the user experience for restricted users, but I've decided to breakup the work in separate PRs
Description 📝
This refactors the
LinodeActionMenuwhile providing disabled tooltips for action items.Tooltips specifically designed for disabled buttons will persist within action menus. These tooltips prove valuable in scenarios where a restricted user has permission to delete their personal resources but lacks the permission to delete those belonging to the admin user. In such cases, we refrain from displaying notices on the page.
Changes 🔄
List any change relevant to the reviewer.
LinodeActionMenudirectory for compartmentalizing filestype ActionTypegetRestrictedResourceTextfor instances where we don't want to be so verbosebuildQueryStringForLinodeCloneinto a util fileTarget release date 🗓️
March 4, 2024
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Read Onlyfor everythingReproduction steps
(How to reproduce the issue, if applicable)
You don't have permission to modify this LinodeVerification steps
(How to verify changes)
read_writeof Linodes for restricted user:trueThis action is unavailable while your Linode is offline.As an Author I have considered 🤔
Check all that apply