upcoming: [M3-7779]: Placement Groups types update, part 2 #10200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
changed the title
abailly-akamai
changed the title
abailly-akamai
force-pushed
the
M3-7779
branch
2 times, most recently
from
6460aac
to
0107d5d
Compare
abailly-akamai
force-pushed
the
M3-7779
branch
from
3a0780a
to
ac168c0
Compare
abailly-akamai
commented
Feb 27, 2024
| id?: number | null; | ||
| compliant_only?: boolean | null; | ||
| id: number; | ||
| compliant_only?: boolean; |
There was a problem hiding this comment.
This is a new undocumented parameter that should be represented in our types ( for API fidelity & SDK purpose) but won't be utilized in Cloud Manager
| linode: number; | ||
| is_compliant: boolean; | ||
| }[]; | ||
| is_strict: boolean; |
There was a problem hiding this comment.
These are the core changes for this PR, resulting in the changes below.
There was a problem hiding this comment.
It's nice to finally have things in sync between specs and our codebase.
| region: Region['id']; | ||
| }; | ||
|
|
||
| export type UpdatePlacementGroupPayload = Pick<PlacementGroup, 'label'>; |
There was a problem hiding this comment.
RenamePlacementGroupPayload isn't the best term from an API standpoint, changing to UpdatePlacementGroupPayload to reflect better the HTTP method
abailly-akamai
requested review from
bnussman-akamai,
jaalah-akamai and
carrillo-erik
and removed request for
a team
hkhalil-akamai
approved these changes
Feb 27, 2024
bnussman-akamai
approved these changes
Feb 27, 2024
|
Coverage Report: ✅ |
|
@abailly-akamai Nice work all around! Everything looks good and ready to go. |
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR bring the latest and greatest API specs updates to the Placement Group feature.
The functionality should be identical and no UI regression is expected from those changes
Changes 🔄
PlacementGroup.linodeschanges from an array of linode IDs to an array of linode objects to include compliance for each linodeRenamePlacementGroupPayloadbecomesUpdatePlacementGroupPayloadcompliant_onlybecomes a silent parameterNote: Not adding a changeset for apiV4 is intentional
Preview 📷
There should be no UI change as a result of this PR
How to test 🧪
Prerequisites
Verification steps
As an Author I have considered 🤔
Check all that apply