-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7577] - Add invoice byline for powered down instances #10208
Conversation
Coverage Report: β
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Confirmed that the blurb appears at the bottom of the last page of the invoice -- wasn't able to find an invoice with the right amount of data to properly test the new page logic, but the code looks good to me
This is good for final approvals/review, I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
const footerText = | ||
'This invoice may include Linode Compute Instances that have been powered off as the data is maintained and resources are still reserved. If you no longer need powered-down Linodes, you can remove the service (https://www.linode.com/docs/products/platform/billing/guides/stop-billing/) from your account.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding your note about adding a link in the PDF, have we considered switching PDF libraries? The last version of jspdf
was published 2 years ago, whereas, something like react-pdf/renderer was published 15 days ago and the package size is smaller by about 1/7.
Description π
In an effort to clarify to customers that they are being charged for powered-down (shutdown) instances, we want to add the following byline to customer invoices:
Note
Adding a link in the PDF added a lot of complexity, so I reached out to Customer Success and they seemed fine with spelling out the link. Open to suggestions to make that better.
Changes π
Target release date ποΈ
3/4/2024
Preview π·
How to test π§ͺ
Verification steps
(How to verify changes)
/account/billing
and look at any invoice*invoices/:invoiceId/items
to check various heightsAs an Author I have considered π€
Check all that apply