-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7697] - Add scrolling for S3 hostnames in the Access Keys modal #10218
Conversation
@@ -59,6 +59,11 @@ export const SecretTokenDialog = (props: Props) => { | |||
|
|||
return ( | |||
<ConfirmationDialog | |||
sx={() => ({ | |||
'.MuiPaper-root': { | |||
overflow: 'hidden', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added to get rid of the unwanted scrollbar in the Modal.
Coverage Report: β
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix works, but it reveals a UI issue (that we may have in a number of places)
if my OS has to only show scrollbars on scroll (system settings > Appearance):
you will never know there's more items to scroll:
The RemovableSelectionList has a drop shadow at the bottom to that effect which I think we want to implement on this component as well
@cpathipa Seeing a small issue where the S3 endpoint field collapses under certain viewports (primarily mobile devices in landscape orientation): |
Great feedback @abailly-akamai and @jdamore-linode addressed PR feedback in the commit c684b0b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for add the drop shadow @cpathipa, looks great π
functionality and styling look good β
I could see a case for adding a unit test for HostNamesList.tsx
, feel free to add one
Description π
Adds scroll bar to S3 endpoint hostnames in Access Keys Modal.
How to test π§ͺ
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
As an Author I have considered π€
Check all that apply