change: [M3-7802] - Remove API caching #10219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
cpathipa and
hkhalil-akamai
and removed request for
a team
bnussman-akamai
changed the title
|
Coverage Report: ✅ |
abailly-akamai
approved these changes
Feb 22, 2024
hkhalil-akamai
approved these changes
Feb 22, 2024
Comment on lines
+29
to
+37
| server.use( | ||
| rest.get('*/regions', (req, res, ctx) => { | ||
| const regions = regionFactory.buildList(1, { | ||
| id: 'us-central', | ||
| label: 'Fake Region, NC', | ||
| }); | ||
| return res(ctx.json(makeResourcePage(regions))); | ||
| }) | ||
| ); |
There was a problem hiding this comment.
I'm not sure if I fully understand why these mocks had to be added. Is the mock from serverHandlers.ts incorrect (I believe it comes from regionsData)? If so, should they be changed/removed from that file?
There was a problem hiding this comment.
The mocks in serverHandlers.ts are the default, but in my opinion, it's best practice to explicitly define any API data that the component depends on in the test itself. This way the unit test will always pass, even if we make changes in serverHandlers.ts , which is something we do frequently.
bnussman-akamai
added
Approved
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
KernelfactoryKerneltype to match what the API actually returnsWhy ❓
yarn buildwithout an internet connection because we no longer need to fetch from the API 🛜What will be removed and why ℹ️
src/cachedData/typesLegacy.jsonbecause it was unusedsrc/cachedData/kernels.jsonbecause it was only used for unit testing (I replaced it with a factory 🏭)src/cachedData/marketplace.jsonbecause the API now responds much faster (~300ms) (use to take many seconds ⏲️ )src/cachedData/regions.jsonbecause it was an over-optimization, not gitignored, and was misused as mock data - see upcoming: [M3-7756] - Placement Groups limits updates #10191 (comment) (this was recently corrected by @abailly-akamai but I don't want it to happen again in the future) 🚓How to test 🧪
As an Author I have considered 🤔