chore: [M3-7803] - Clean up Chip component
#10223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
jdamore-linode and
jaalah-akamai
and removed request for
a team
|
Coverage Report: ❌ |
dwiley-akamai
requested changes
Feb 23, 2024
Comment on lines
127
to
134
| {hasUpgrade && ( | ||
| <Chip | ||
| clickable | ||
| inTable | ||
| label="UPGRADE" | ||
| onClick={openUpgradeDialog} | ||
| size="small" | ||
| /> | ||
| ) : null} | ||
| )} |
There was a problem hiding this comment.
The "Upgrade" chip was adversely impacted by some of the styling changes:
| Prod | This branch |
|---|---|
 |
 |
There was a problem hiding this comment.
Comment on lines
152
to
171
| <Stack | ||
| alignItems="center" | ||
| aria-label={`Linode status ${linodeStatus}`} | ||
| component="span" | ||
| data-qa-linode-status | ||
| hasSecondaryStatus={hasSecondaryStatus} | ||
| isOffline={isOffline} | ||
| isOther={isOther} | ||
| isRunning={isRunning} | ||
| isSummaryView={isSummaryView} | ||
| label={formattedStatus} | ||
| pill={true} | ||
| /> | ||
| direction="row" | ||
| spacing={1.5} | ||
| sx={{ paddingLeft: 2 }} | ||
| > | ||
| <StatusIcon status={getLinodeIconStatus(linodeStatus)} /> | ||
| <Typography sx={(theme) => ({ fontFamily: theme.font.bold })}> | ||
| {formattedStatus} | ||
| </Typography> | ||
| </Stack> | ||
| {isRebootNeeded && ( | ||
| <TooltipIcon | ||
| status="help" | ||
| sxTooltipIcon={{ padding: 0 }} | ||
| text={VPC_REBOOT_MESSAGE} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
Similar to the K8S "Upgrade" chip situation:
| Prod | This branch |
|---|---|
 |
 |
There was a problem hiding this comment.
Fixed in 63bb02e
dwiley-akamai
approved these changes
Feb 23, 2024
bnussman-akamai
added
Approved
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
After talking about Chips in our cafe meeting, I looked at the Chip component and I couldn't un-see some of this code 😩😤
This PR simplifies our override of MUI's
<Chip />and removes some styled components that went way too farPreview 📷
Note
The goal of this PR is to clean up Chip related code, but not change to how it looks 👁️
How to test 🧪
Chipyou can think of in Cloud ManagerAs an Author I have considered 🤔