-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7814, M3-7819] - Fix Account Switching #10234
Conversation
// We don't need to worry about this if we're a proxy user. | ||
if (!isProxyUser) { | ||
const parentToken = { | ||
const parentToken: Token = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More type safety
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- From a parent account, I can switch to a proxy account.
- From a proxy account, I can switch to another proxy account.
- From a proxy account, I can switch back to a parent account.
Coverage Report: β
|
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Awesome! Confirmed that the tests now pass without the workarounds (and pushed a commit with those workarounds removed). Feels like a big milestone!
Description π
There were a few issues with proxy tokens and loading child users for proxy accounts.
Changes π
Bearer
was missing from the proxy token sending us back to login upon switching.ChildAccountList
which prevented us from fetching child accounts while in a proxy account. This token needs to be the parent token when logged in as a proxy.Target release date ποΈ
03/04/2024
Preview π·
parent-child.mp4
How to test π§ͺ
Prerequisites
(How to setup test environment)
Verification steps
As an Author I have considered π€
Check all that apply