Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7727] - Only support Edge to Edge Migrations #10238

Merged

Conversation

hana-linode
Copy link
Contributor

@hana-linode hana-linode commented Feb 28, 2024

Description πŸ“

We want to cultivate that edge instances are different from core instances. So, migrating a Linode instance from core to edge or from edge to core should not be possible. Only edge-to-edge migrations and core-to-core migrations should be possible.

Changes πŸ”„

List any change relevant to the reviewer.

  • Hide core regions if the current Linode is in an edge region
  • Hide edge regions if the current Linode is in a core region

Preview πŸ“·

image

How to test πŸ§ͺ

Verification steps

(How to verify changes)

  • Turn on the MSW
  • Open the Migrate Linode dialog via the Linodes landing table dropdown action or Linode details header dropdown action
  • Observe the current region is an edge region and the New region input only contains edge regions
  • Change line 770 in serverHandlers.ts to a core region like us-east
  • Hard refresh the page and open the Migrate Linode dialog again
  • Observe the current region is a core region and the New region input only contains core regions

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@hana-linode hana-linode added the Gecko Beta Relating to Gecko project label Feb 28, 2024
@hana-linode hana-linode self-assigned this Feb 28, 2024
@hana-linode hana-linode marked this pull request as ready for review February 28, 2024 18:06
@hana-linode hana-linode requested a review from a team as a code owner February 28, 2024 18:06
@hana-linode hana-linode requested review from jdamore-linode and abailly-akamai and removed request for a team February 28, 2024 18:06
Copy link

github-actions bot commented Feb 28, 2024

Coverage Report: ❌
Base Coverage: 81.32%
Current Coverage: 81.28%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks for the change 🧹

Code looks good and filtering is working as expected βœ…

@hana-linode hana-linode added the Add'tl Approval Needed Waiting on another approval! label Mar 1, 2024
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 4, 2024
@hana-linode hana-linode merged commit b8c1e45 into linode:develop Mar 4, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Gecko Beta Relating to Gecko project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants