-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7727] - Only support Edge to Edge Migrations #10238
Merged
hana-linode
merged 8 commits into
linode:develop
from
hana-linode:M3-7727-edge-site-migrations
Mar 4, 2024
Merged
upcoming: [M3-7727] - Only support Edge to Edge Migrations #10238
hana-linode
merged 8 commits into
linode:develop
from
hana-linode:M3-7727-edge-site-migrations
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-linode
requested review from
jdamore-linode and
abailly-akamai
and removed request for
a team
February 28, 2024 18:06
packages/manager/src/features/Linodes/MigrateLinode/ConfigureForm.tsx
Outdated
Show resolved
Hide resolved
Coverage Report: β |
packages/manager/src/features/Linodes/MigrateLinode/ConfigureForm.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/MigrateLinode/ConfigureForm.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/MigrateLinode/ConfigureForm.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/RegionSelect/RegionSelect.utils.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/RegionSelect/RegionSelect.types.ts
Outdated
Show resolved
Hide resolved
abailly-akamai
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! thanks for the change π§Ή
Code looks good and filtering is working as expected β
bnussman-akamai
approved these changes
Mar 4, 2024
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Mar 4, 2024
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description π
We want to cultivate that edge instances are different from core instances. So, migrating a Linode instance from core to edge or from edge to core should not be possible. Only edge-to-edge migrations and core-to-core migrations should be possible.
Changes π
List any change relevant to the reviewer.
Preview π·
How to test π§ͺ
Verification steps
(How to verify changes)
770
inserverHandlers.ts
to a core region likeus-east
As an Author I have considered π€
Check all that apply