Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7724] - Linode plan table updates for Edge regions #10255

Merged

Conversation

hana-linode
Copy link
Contributor

@hana-linode hana-linode commented Mar 4, 2024

Description πŸ“

API work for Edge plans will not be ready for Beta. So, we need to hardcode the plans ourselves until then.

Changes πŸ”„

List any change relevant to the reviewer.

  • Edge regions will only display dedicated plans minus the 256gb and 516gb plans
  • Edge region price is $0 for Beta and a warning explanation notice is displayed

Preview πŸ“·

image
image

How to test πŸ§ͺ

Prerequisites

(How to setup test environment)

  • Ensure you have the right customer tag for testing new dcs (reach out for more info)

Verification steps

(How to verify changes)

  • Go to /linodes/create and select an Edge region
  • You should not see the tab control, only the Dedicated Linode Plan Table minus the 256gb and 516gb plans
  • The summary section should reflect the $0 price
  • Core regions should still display the same plans as prod

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@hana-linode hana-linode added the Gecko Beta Relating to Gecko project label Mar 4, 2024
@hana-linode hana-linode self-assigned this Mar 4, 2024
@hana-linode hana-linode marked this pull request as ready for review March 6, 2024 15:39
@hana-linode hana-linode requested a review from a team as a code owner March 6, 2024 15:39
@hana-linode hana-linode requested review from bnussman-akamai, cpathipa and jaalah-akamai and removed request for a team March 6, 2024 15:39
@jaalah
Copy link
Contributor

jaalah commented Mar 6, 2024

I'm auto enrolled in backups, so we need to address this use-case.
Screenshot 2024-03-06 at 1 23 45 PM

// 256gb and 516gb plans will not be supported for Edge
const plansUpTo128GB = planTypes.dedicated.slice(
0,
planTypes.dedicated.length - 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to double check that this will still work with the 512GB decommissioning work we're doing here: https://github.com/linode/manager/pull/10228/files#diff-eef38141ba2a3f5898e288b786fa5ad972dace25bfd5ad823c481f22ec89f366R65-R67. At first glance we should be fine, but let's keep an eye on this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be fine for the immediate future, but I think it'd be safer and more maintainable to remove the 256GB and 512GB plans specifically from the array instead of the last two elements (reason being, if in a few months API turns off the 512GB plan and we don't insert the placeholder, this logic would end up removing the 128GB plan too)

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything the other guy said πŸ˜‰

Copy link

github-actions bot commented Mar 8, 2024

Coverage Report: βœ…
Base Coverage: 81.39%
Current Coverage: 81.39%

@hana-linode hana-linode added Add'tl Approval Needed Waiting on another approval! and removed Work in Progress labels Mar 11, 2024
@dwiley-akamai dwiley-akamai self-requested a review March 11, 2024 15:47
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Linode Create page:

  • (for Edge regions) You should not see the tab control, only the Dedicated Linode Plan Table minus the 256gb and 512gb plans βœ…
  • (for Edge regions) The summary section should reflect the $0 price βœ…
  • Core regions should still display the same plans as prod βœ…

// 256gb and 516gb plans will not be supported for Edge
const plansUpTo128GB = planTypes.dedicated.slice(
0,
planTypes.dedicated.length - 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be fine for the immediate future, but I think it'd be safer and more maintainable to remove the 256GB and 512GB plans specifically from the array instead of the last two elements (reason being, if in a few months API turns off the 512GB plan and we don't insert the placeholder, this logic would end up removing the 128GB plan too)

@hana-linode hana-linode merged commit 0830c44 into linode:develop Mar 12, 2024
17 of 18 checks passed
@hana-linode hana-linode added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Gecko Beta Relating to Gecko project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants