change: [UIE-7308] - Notifications for database resize events #10262

mpolotsk-akamai · 2024-03-06T16:19:16Z

Description 📝

Needs to be tested on DEV/ALPHA

Bell icon / Alert changes:
System notify users when database resizing starts, display a progress bar which disappears upon completion, update status from 'Active' to 'Resizing', show resizing progress in percentage, and revert to 'Active' status when finished.
Option to switch between dedicated and shared plans, with the exception of switching from dedicated plan to a shared plan of the same size.

Changes 🔄

Notification / Event of resizing Start
Notification progress bar in Bell icon Alert
Notification complete – bar disappears
Shared to dedicated and back plan change
Status Changes from Active to Resizing
Rendering progress % numbers in UI
Changing back to Active when done

Target release date 🗓️

Release date 3/18/24

Preview 📷

How to test 🧪

Needs to be tested in Alpha.
Open application, navigate to /databases, select the database cluster. Go to the Resize tab, choose a plan, and click the 'Resize Database Cluster' button. In the popup window, confirm the resizing by entering the name of the database cluster, then click 'Resize Cluster' button. You can monitor the resizing status in the Summary and Resize tabs, as well as in a table on the Databases page. Additionally, notification about scheduled resizing and a progress bar which disappears upon completion in bell icon dropdown.

carrillo-erik · 2024-03-06T17:15:25Z

Could you please share any insight with the following..

When an action is successful we denote the toast notifications with green color.

Here is an example for volume being resized.

Also, there is a discrepancy with the copy of the toast notification. Normally, only notifications for account or profile actions will start the message with Your ...

mpolotsk-akamai · 2024-03-07T12:41:19Z

Could you please share any insight with the following..

When an action is successful we denote the toast notifications with green color.

Here is an example for volume being resized.

Also, there is a discrepancy with the copy of the toast notification. Normally, only notifications for account or profile actions will start the message with Your ...

We have a blue notification (info) indicating that the database cluster will be resized, similar to the behavior of Linode Resize.
A green notification (success) means, for example, that the database was successfully resized, indication successful completion, while red notification indicates that the action was not successful.

Regarding the text in the notification I will update it to "Database cluster {cluster name} is being resized."

abailly-akamai

Thanks for the solid PR!

a few things overall:

make sure to use strict equality
You have unit test failures (run yarn test or look at GH action report
this is lacking coverage (unit test in this PR, and is there any plan to add e2e coverage?)
You need to rebase this PR to get the latest changes from develop
Make sure to add screenshots about what I am expected to see in the UI in your PR description
Am not seeing the progress bar. Is it only in alpha? If so, please add that the PR needs to be tested with alpha

packages/manager/.changeset/pr-10262-changed-1709742412767.md

packages/manager/src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.tsx

.../src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResizeCurrentConfiguration.tsx

...rc/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryClusterConfiguration.tsx

packages/manager/src/features/components/PlansPanel/PlanContainer.tsx

packages/manager/src/features/components/PlansPanel/PlanSelection.tsx

packages/manager/src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.tsx

mpolotsk-akamai · 2024-03-07T15:05:11Z

@abailly-akamai thank you for your review! I'll make the necessary changes.

github-actions · 2024-03-11T15:28:05Z

Coverage Report: ❌
Base Coverage: 81.45%
Current Coverage: 81.42%

abailly-akamai

Thanks @mpolotsk-akamai the PR is looking good.

Please add to the description that this needs to be tested on DEV/ALPHA (I imagine this is not going live for a while and still behind a feature flag?
Left some code clean up comments

Was able to confirm the events and the progress bar however, I am getting an error in the console about an unknown API event received, which seems to be directly related to the resize event. Can you look into it?

packages/manager/src/features/Databases/DatabaseDetail/DatabaseStatusDisplay.tsx

packages/manager/src/features/components/PlansPanel/PlanContainer.tsx

abailly-akamai · 2024-03-13T13:54:25Z

packages/manager/src/features/components/PlansPanel/PlanSelection.tsx

+  sizeTooSmall: boolean,
+  planIsDisabled?: boolean,
+  disabledToolTip?: string
+): string | undefined => {


nitpick: above 2 arguments, use named args

packages/manager/src/features/components/PlansPanel/PlanSelection.tsx

mpolotsk-akamai · 2024-03-13T16:45:23Z

Thanks @mpolotsk-akamai the PR is looking good.

Please add to the description that this needs to be tested on DEV/ALPHA (I imagine this is not going live for a while and still behind a feature flag?

Left some code clean up comments

Was able to confirm the events and the progress bar however, I am getting an error in the console about an unknown API event received, which seems to be directly related to the resize event. Can you look into it?

@abailly-akamai, thank you for the review!

I encountered the same issue. It occurs when we have old events in the dropdown menu. Sam Klock provided an explanation:
"If you're referring to an event for a job that occurred before we enabled the new event types in Alpha, then this behavior is expected; the new types aren't applied retroactively."

One of the ways to resolve this is by keeping the copy defined for "database_scale" in the code, as there will be users who have event records for it in production. So, I will add database_scale to eventMessageGenerator.

packages/manager/src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.tsx

packages/manager/src/features/components/PlansPanel/PlanContainer.tsx

packages/manager/src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.tsx

hana-linode

Can we extend the width of the loading bar to match the container?

example from the MSW

Generally, settings are positioned as the last tab content instead of the middle. Can we move the Resize tab next to Backups instead of at the end?

examples

.../src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResizeCurrentConfiguration.tsx

packages/manager/src/features/Databases/DatabaseDetail/DatabaseStatusDisplay.test.tsx

packages/manager/src/features/Databases/DatabaseDetail/DatabaseStatusDisplay.tsx

packages/manager/src/features/components/PlansPanel/PlanSelection.tsx

hana-linode · 2024-03-18T18:28:11Z

@mpolotsk-akamai looks like there are merge conflicts that need to be addressed

…hich disappears after resize complete, update status from Active to Resizing, show resizing progress in percentage, and revert to Active status when finished. Option to switch between dedicated and shared plans, with the exception of switching from dedicated plan to a shared plan of the same size.

mpolotsk-akamai · 2024-03-18T20:53:36Z

@hana-linode , merge conflicts have been resolved

carrillo-erik · 2024-03-20T12:55:56Z

Thanks for making the changes.

mpolotsk-akamai requested a review from a team as a code owner March 6, 2024 16:19

mpolotsk-akamai requested review from hana-linode and abailly-akamai and removed request for a team March 6, 2024 16:19

bnussman-akamai assigned mpolotsk-akamai Mar 7, 2024

bnussman-akamai added the DBaaS Relates to Database as a Service label Mar 7, 2024

abailly-akamai reviewed Mar 7, 2024

View reviewed changes

mpolotsk-akamai force-pushed the feature/UIE-7308-cloud-manager-changes-for-DBAAS branch from c7fcb73 to b6f35f6 Compare March 8, 2024 14:53

mpolotsk-akamai requested a review from abailly-akamai March 12, 2024 13:48

abailly-akamai reviewed Mar 13, 2024

View reviewed changes

mpolotsk-akamai requested a review from abailly-akamai March 13, 2024 18:16

abailly-akamai approved these changes Mar 13, 2024

View reviewed changes

carrillo-erik requested changes Mar 14, 2024

View reviewed changes

hana-linode changed the title ~~change: [UIE-7308] - notification for resizing database~~ change: [UIE-7308] - Notifications for database resize events Mar 14, 2024

hana-linode reviewed Mar 14, 2024

View reviewed changes

mpolotsk-akamai requested review from hana-linode and carrillo-erik March 18, 2024 14:47

hana-linode changed the base branch from develop to release-v1.115.0 March 18, 2024 16:11

hana-linode changed the base branch from release-v1.115.0 to develop March 18, 2024 16:27

mpolotsk-akamai added 5 commits March 18, 2024 20:24

change: [UIE-7308] - notification for resizing database

ef2afce

Added changeset: Added event type for database resize create

372da20

change: [UIE-7308] - refactoring

9d3d4f6

change: [UIE-7308] - refactoring

6d4c207

mpolotsk-akamai added 4 commits March 18, 2024 20:24

change: [UIE-7308] - add DatabaseStatusDisplay component

fcd7078

change: [UIE-7308] - refactoring

76006cc

change: [UIE-7308] - refactoring

9a57f53

change: [UIE-7308] - resolve merge conflicts

7b980d7

mpolotsk-akamai force-pushed the feature/UIE-7308-cloud-manager-changes-for-DBAAS branch from c135d39 to 7b980d7 Compare March 18, 2024 20:29

hana-linode approved these changes Mar 19, 2024

View reviewed changes

hana-linode added the Approved Multiple approvals and ready to merge! label Mar 19, 2024

carrillo-erik approved these changes Mar 20, 2024

View reviewed changes

hana-linode merged commit 874584c into linode:develop Mar 21, 2024
18 checks passed

This was referenced Mar 28, 2024

Release v1.116.0 - release → staging #10327

Merged

Release v1.116.0 - staging → master #10335

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change: [UIE-7308] - Notifications for database resize events #10262

change: [UIE-7308] - Notifications for database resize events #10262

mpolotsk-akamai commented Mar 6, 2024 •

edited

carrillo-erik commented Mar 6, 2024 •

edited

mpolotsk-akamai commented Mar 7, 2024 •

edited

abailly-akamai left a comment

mpolotsk-akamai commented Mar 7, 2024

github-actions bot commented Mar 11, 2024 •

edited

abailly-akamai left a comment

abailly-akamai Mar 13, 2024

mpolotsk-akamai commented Mar 13, 2024

hana-linode left a comment

hana-linode commented Mar 18, 2024

mpolotsk-akamai commented Mar 18, 2024

carrillo-erik commented Mar 20, 2024

change: [UIE-7308] - Notifications for database resize events #10262

change: [UIE-7308] - Notifications for database resize events #10262

Conversation

mpolotsk-akamai commented Mar 6, 2024 • edited

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

carrillo-erik commented Mar 6, 2024 • edited

mpolotsk-akamai commented Mar 7, 2024 • edited

abailly-akamai left a comment

Choose a reason for hiding this comment

mpolotsk-akamai commented Mar 7, 2024

github-actions bot commented Mar 11, 2024 • edited

abailly-akamai left a comment

Choose a reason for hiding this comment

abailly-akamai Mar 13, 2024

Choose a reason for hiding this comment

mpolotsk-akamai commented Mar 13, 2024

hana-linode left a comment

Choose a reason for hiding this comment

hana-linode commented Mar 18, 2024

mpolotsk-akamai commented Mar 18, 2024

carrillo-erik commented Mar 20, 2024

mpolotsk-akamai commented Mar 6, 2024 •

edited

carrillo-erik commented Mar 6, 2024 •

edited

mpolotsk-akamai commented Mar 7, 2024 •

edited

github-actions bot commented Mar 11, 2024 •

edited