Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-7856] - Update ACLB Match Condition Tooltips and Placeholders #10271

Conversation

bnussman-akamai
Copy link
Contributor

@bnussman-akamai bnussman-akamai commented Mar 11, 2024

Description πŸ“

We were not recommending valid values to the user. This PR updates our placeholders and tooltips to use the correct format of key=value

Preview πŸ“·

Before After
Screenshot 2024-03-11 at 12 03 00β€―PM Screenshot 2024-03-11 at 12 02 35β€―PM

How to test πŸ§ͺ

Prerequisites

  • Use the MSW, dev-test-aglb, or prod-test-065

How to verify

  • Go the an existing ACLB
  • Go to the routes tab
  • Create a route if none exits
  • On a route, open the add rule drawer
  • In this drawer, verify the tooltip and placeholder text uses key=value format for header and query string matches

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@bnussman-akamai bnussman-akamai added the ACLB Relating to the Akamai Cloud Load Balancer label Mar 11, 2024
@bnussman-akamai bnussman-akamai self-assigned this Mar 11, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review March 11, 2024 16:22
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner March 11, 2024 16:22
@bnussman-akamai bnussman-akamai requested review from hana-linode and cpathipa and removed request for a team March 11, 2024 16:22
Copy link

Coverage Report: βœ…
Base Coverage: 81.39%
Current Coverage: 81.39%

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Mar 12, 2024
@hana-linode hana-linode added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 12, 2024
@bnussman-akamai bnussman-akamai merged commit b2c985c into linode:develop Mar 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants