-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-6606] - Add spacing between copy and Linode Rebuild button. #10283
Conversation
Can we make the button right aligned? (flex-end) |
Also, because there is only one button, I think it would be a lot cleaner to just use a plain "Button" (no |
If we did that, I wonder if it would look weird with the left-aligned "Add an SSH Key" button right above? (Or would you suggest right-aligning that too?)
+1 |
Coverage Report: β
|
I think we have a similar pattern of having some buttons on the left and some on the right, as seen in the Linode create flow. IMO, it would be beneficial to render action buttons with the ActionsPanel component since it supports rendering both primary and secondary action buttons. Also, it would enhance the maintainability of primary and secondary action buttons across the CM. |
packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/RebuildFromStackScript.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/RebuildFromStackScript.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/RebuildFromStackScript.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Description π
Add's spacing between copy and Linode Rebuild button.
How to test π§ͺ
Verification steps
(How to verify changes)
As an Author I have considered π€
Check all that apply