fix: [M3-7864] - Make the ACL (Object storage) select field carat (^) symbol consist with other select fields in the CM. #10286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… symbol consist with other select fields in the CM.
cpathipa
requested review from
bnussman-akamai and
hkhalil-akamai
and removed request for
a team
… symbol consist with other select fields in the CM.
packages/manager/src/features/ObjectStorage/BucketDetail/AccessSelect.tsx
Outdated
Show resolved
Hide resolved
@bnussman-akamai Addressed this issue in882d90e |
hkhalil-akamai
approved these changes
Mar 18, 2024
|
Unit tests need to be fixed! |
|
Coverage Report: ✅ |
packages/manager/src/features/ObjectStorage/BucketDetail/AccessSelect.test.tsx
Outdated
Show resolved
Hide resolved
cpathipa
requested review from
jdamore-linode and
bnussman-akamai
and removed request for
a team
mjac0bs
reviewed
Mar 29, 2024
packages/manager/cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts
Outdated
Show resolved
Hide resolved
….e2e.spec.ts Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
mjac0bs
approved these changes
Apr 1, 2024
mjac0bs
added
Approved
jdamore-linode
approved these changes
Apr 1, 2024
bnussman-akamai
pushed a commit
to bnussman-akamai/manager
that referenced
this pull request
Apr 4, 2024
… symbol consist with other select fields in the CM. (linode#10286) * fix: [M3-7864] - Make the ACL (Object storage) select field carat (^) symbol consist with other select fields in the CM. * Added changeset: Make the ACL (Object storage) select field carat (^) symbol consist with other select fields in the CM. * Update selected value according to Autocomplete * Update broken unit test * Update AccessSelect.test.tsx * Add e2e tests to view and update Bucket access (ACL) * Update tests for AccessSelect refactor * Remove mocking * Update packages/manager/cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/.changeset/pr-10286-fixed-1710435081738.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Show loading state for ACL select field. --------- Co-authored-by: Joe D'Amore <jdamore@linode.com> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test 🧪
Verification steps
(How to verify changes)
AccessSelectreferences and ensure there is no regression.As an Author I have considered 🤔
Check all that apply