upcoming: [M3-7879] - Linode Create Refactor - Part 4 - Access #10308
Conversation
bnussman-akamai
requested review from
dwiley-akamai and
hana-linode
and removed request for
a team
| return ( | ||
| <Paper> | ||
| <React.Suspense | ||
| fallback={<Skeleton sx={{ height: '89px', maxWidth: '416px' }} />} |
There was a problem hiding this comment.
This is how we use to handle this component. We lazy load it because it is heavy. I switched the fallback to a Skeleton that is the same size as the PasswordInput so that content won't have a chance to shift
There was a problem hiding this comment.
This is just a newer, cleaner, simpler version of packages/manager/src/components/AccessPanel/AccessPanel.tsx
bnussman-akamai
requested review from
jaalah-akamai,
abailly-akamai and
hkhalil-akamai
|
Coverage Report: ✅ |
| return ( | ||
| <Paper> | ||
| <React.Suspense | ||
| fallback={<Skeleton sx={{ height: '89px', maxWidth: '416px' }} />} |
There was a problem hiding this comment.
What are you thoughts of setting 416 as a constant and use it where we're setting the maxWidth for inputs in other places to? If that ever changes and someone forgets to update this, the skeleton will be off
There was a problem hiding this comment.
4d81095 It now pulls from an existing constant. Should I make the change globally where 416 is hardcoded?
| export const Access = () => { | ||
| const { control } = useFormContext<CreateLinodeRequest>(); | ||
|
|
||
| const isLinodeCreateRestricted = useRestrictedGlobalGrantCheck({ |
There was a problem hiding this comment.
Nit: We typically have been calling the variable for this hook is{Resource}ReadOnly. I'm open to whatever, but we should probably find a common convention
There was a problem hiding this comment.
We could force that naming convention through the hook
bnussman-akamai
added
Add'tl Approval Needed
There was a problem hiding this comment.
No additional comments after code-review and manual testing... great work @bnussman-akamai!
Description 📝
Preview 📷
How to test 🧪
You can test via the preview link if you want!
Linode Create v2feature flag is toggled on using our dev toolsAs an Author I have considered 🤔