upcoming: [M3-7927] - Linode Create Refactor - Part 6 - Add-ons

[bnussman-akamai]

Description 📝

Adds the "Add-ons" section to the new Linode Create Flow 🎉

Changes 🔄

• Adds the "Add-ons" section to the new Linode Create flow
  • The ability to add a private IP 🔌
  • The ability to enable backups 💾
• Adds jsdoc style comments to the Linode Create type in api-v4 📝 (copy paste from API spec)
• Allows firewall_id to be null in the Linode Create type because the API allows it ✅

Preview 📷

How to test 🧪

Prerequisites

• Turn on the new Linode Create Flow feature flag using your local dev tools 🎏 (you can use the preview link or checkout this PR)

Verification steps

• Go to the Linode Create Flow
• Test general create flow functionality
• Test both the Private IP checkbox and the Backups checkbox ☑️
• Check my code for anything unreadable or questionable 📖
• Verify unit tests are sufficient 🧪

As an Author I have considered 🤔

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[bnussman-akamai]

There are other notices that will need to be added here related to cloning. I will add those when I add cloning support down the road.

[github-actions]

Coverage Report: ✅
Base Coverage: 81.69%
Current Coverage: 81.69%

[jaalah-akamai]

Thanks for all the doc improvements and tests. This is looking great 🚀

[dwiley-akamai]

Disabled flow for restricted user w/o Linode Create permissions, functional for unrestricted users ✅

Add-Ons section disabled when Edge region selected ✅

Code review ✅

[abailly-akamai]

Nice and super well tested 🎉

• Confirmed behavior of the form and payload ✅
• Confirmed a null firewall_id is taken by the API ✅

Left a couple non blocking comments

Also, reminder to add the default values to the distro and details label

[abailly-akamai]

are we still doing fragments this way rather than <>?

[bnussman-akamai]

This was just copy paste from packages/manager/src/features/Linodes/LinodesCreate/AddonsPanel.tsx. I'm open to using <> if we want to prefer that

[abailly-akamai]

I am still finding this a bit flawed. Yes, this is relatively inexpensive but because of only storing the region ID in the form state instead of the whole region object we are probably running regions.find 5 or 6 times on the Linode create flow - maybe more. Not a big deal but not the cleanest

[bnussman-akamai]

Yeah, this is a great point. I was considering adding a useRegion query to avoid needing to run a regions.find everywhere, but this could introduce an extra fetch.

This might be worth it considering how often we call regions.find throughout the app

Have any thoughts on that or other ideas?

[abailly-akamai]

Would it be possible/a good idea to break pattern and have the form state being the whole region?

[bnussman-akamai]

I don't think that would be great. I think it would make things a ton more complicated with regarding types and validation

[abailly-akamai]

makes sense. then i think the best option would be a useMemo util so at least we're not recalculating every time?