fix: [M3-7605] - Wrong status indicator when provisioning a LKE #10320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-linode
added
Bug
hana-linode
commented
Mar 27, 2024
Comment on lines
+57
to
+58
| nodeStatus === 'not_ready' | ||
| ? 'other' |
There was a problem hiding this comment.
This was the actual fix
| import { useInProgressEvents } from 'src/queries/events/events'; | ||
|
|
||
| import NodeActionMenu from './NodeActionMenu'; | ||
| import { StyledCopyTooltip, StyledTableRow } from './NodeTable.styles'; |
There was a problem hiding this comment.
This file was basically migrated from NodeTable along with some styling migration
hana-linode
requested review from
bnussman-akamai and
cpathipa
and removed request for
a team
jdamore-linode
approved these changes
Mar 28, 2024
cpathipa
approved these changes
Mar 28, 2024
| ? 'Provisioning' | ||
| : transitionText(instanceStatus ?? '', instanceId ?? -1, recentEvent); | ||
|
|
||
| const displayIP = ip ?? ''; |
There was a problem hiding this comment.
Do we need direct usage of ip instead of displayIP? Since we are conditionally rendering the consumers of displayIP, which will handle undefined cases, can we directly use ip?
Comment on lines
+53
to
+61
| const nodeReadyAndInstanceRunning = | ||
| nodeStatus === 'ready' && instanceStatus === 'running'; | ||
|
|
||
| const iconStatus = | ||
| nodeStatus === 'not_ready' | ||
| ? 'other' | ||
| : nodeReadyAndInstanceRunning | ||
| ? 'active' | ||
| : 'inactive'; |
There was a problem hiding this comment.
Can we simplify the determination of iconStatus by directly incorporating the conditions?
const iconStatus =
nodeStatus === 'not_ready'
? 'other'
: nodeStatus === 'ready' && instanceStatus === 'running'
? 'active'
: 'inactive';
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fix the status icon indicator when a Kubernetes Linode is provisioning from grey to pulsing orange. I also went ahead and did some styling/file cleanup.
Preview 📷
Screen.Recording.2024-03-27.at.10.36.48.AM.mov
How to test 🧪
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply